Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't modify the method combination of MAKE-INSTANCE on sbcl #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't modify the method combination of MAKE-INSTANCE on sbcl #18

wants to merge 1 commit into from

Conversation

csrhodes
Copy link

since sbcl-1.4.8 or so, it doesn't work. Closes #17

@csrhodes
don't modify the method combination of MAKE-INSTANCE on sbcl
8b77b1e 
since sbcl-1.4.8 or so, it doesn't work.  Closes sellout#17
sellout
sellout requested changes Jul 5, 2018
View reviewed changes
Copy link
Owner

@sellout sellout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Can you update the comment as well to something like “These implementations explode …”.

Also, if you have any suggestions for how we can support creation-time checking of invariants more widely, I’m all ears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sellout sellout sellout requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csrhodes @sellout