Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] API job_progress shouldn't returns the data field of job progress #271

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Nov 27, 2024

issue : #263

before

{"success":true,"job_progress":"{\"job_name\":\"test\",\"sync_state\":501,\"sub_sync_state\":{\"state\":-1,\"binlog_type\":-1},\"job_sync_id\":1732704080,\"prev_commit_seq\":7033,\"commit_seq\":7033,\"table_mapping\":null,\"table_commit_seq_map\":null,\"data\":\"{\\\"commit_seq\\\":7033,\\\"txn_id\\\":2007,\\\"dest_table_ids\\\":[63037],\\\"table_records\\\":[{\\\"_\\\":63025,\\\"partitionRecords\\\":[{\\\"partitionId\\\":63024,\\\"range\\\":\\\"\\\",\\\"version\\\":4,\\\"isTempPartition\\\":false,\\\"stid\\\":-1}],\\\"indexIds\\\":[63026]}],\\\"commit_infos\\\":[{\\\"tabletId\\\":63040,\\\"backendId\\\":10005},{\\\"tabletId\\\":63042,\\\"backendId\\\":10005},{\\\"tabletId\\\":63044,\\\"backendId\\\":10005}],\\\"is_txn_insert\\\":false,\\\"source_stid\\\":null,\\\"desc_stid\\\":null,\\\"sub_txn_infos\\\":null}\",\"created_at\":1732704079,\"full_sync_start_at\":1732704079,\"incremental_sync_start_at\":1732704121,\"ingest_binlog_at\":1732704181}"}

now

{"success":true,"job_progress":{"job_name":"test","sync_state":501,"sub_sync_state":{"state":-1,"binlog_type":-1},"job_sync_id":1732704080,"prev_commit_seq":7033,"commit_seq":7033,"table_mapping":null,"table_commit_seq_map":null,"data":"","created_at":1732704079,"full_sync_start_at":1732704079,"incremental_sync_start_at":1732704121,"ingest_binlog_at":1732704181}}

pkg/service/http_service.go Outdated Show resolved Hide resolved
pkg/service/http_service.go Outdated Show resolved Hide resolved
@w41ter w41ter merged commit e5db4fa into selectdb:dev Nov 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants