This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 256
Player Tracking Stats #109
Open
BenikaH
wants to merge
13
commits into
seemethere:master
Choose a base branch
from
BenikaH:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added endpoints for player tracking to get second spectrum stats.
Changed current season to 2017-18 in constants.py.
I have found 24 endpoints from stats.nba.com that are not currently included in nba_py Here are first 6 new endpoints in 6 new classes that can hopefully be added to the master repo I'm quite new to Python and GitHub so please let me know if I'm doing anything wrong, but hopefully I did enough testing on these classes before committing.
Fixed Travis CI suggestions
Added some parameters that aren't required but can be provided anyway
Team hustle stats! Two new endpoints with their classes: TeamHustleLeaders (endpoint: leaguehustlestatsteamleaders) and TeamHustleStats (endpoint: leaguehustlestatsteam)
Player hustle stats added! 10 of 24 new endpoints now added (if you include teams.py). In this update: Two new endpoints with their classes: PlayerHustleLeaders (endpoint: leaguehustlestatsplayerleaders) and PlayerHustleStats (endpoint: leaguehustlestatsplayer)
fixed Travis CI whitespace issues and added call to _api_scrape inside TeamHustleStats
Travis CI whitespace issues fixed
Updated functionality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the endpoints and PTMeasureType for the second spectrum stats available on stats.nba.com.
Hope this is useful for other nba_py users.