Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject providers individually #796

Conversation

victorkirov
Copy link
Member

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement

📜 Background

Currently leather injects stacks provider immutably. This breaks our injection of the stacks and btc providers since we inject them together. We need to inject them one by one.

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link

@m-aboelenein m-aboelenein merged commit 43b1b01 into develop Feb 13, 2024
5 checks passed
@m-aboelenein m-aboelenein deleted the victor/eng-3764-inject-stacks-and-btc-providers-separately branch February 13, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants