Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert getBrc20Tokens to sequential call #769

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

jordankzf
Copy link
Contributor

🔘 PR Type

What kind of change does this PR introduce?

On a newly restored wallet, brcCoinsList will not be populated. As a such, the previous concurrent API calls will not be aware of owned ordinals which will cause no fiat value to be displayed for brc20 tokens. This PR will revert the concurrent calls to a sequential order, which has a slight speed impact, but will ensure that the fiat value will always be displayed.

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.

Issue Link: #[issue_number]
Context Link (if applicable):

🔄 Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.

🖼 Screenshot / 📹 Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link

@teebszet teebszet merged commit e366817 into develop Jan 25, 2024
5 checks passed
@teebszet teebszet deleted the jordankzf/brc20-concurrency branch January 25, 2024 08:18
jordankzf added a commit that referenced this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants