Fix typing between sats connect and extension for providers #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-aboelenein
changed the base branch from
develop
to
mahmoud/eng-3370-improve-get-address-screen
…ix-sats-connect-typing
m-aboelenein
approved these changes
Jan 25, 2024
|
Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7653146693 |
teebszet
pushed a commit
that referenced
this pull request
Jan 26, 2024
* init getAddress screen revamp * update ui * update btc address select request * update stx screen and add btcAddress to stacks connect response * ui fixes * minor fixes * disable account actions on connection requests * added icon borderRadius * remove debug log * Fix typing between sats connect and extension for providers (#768) * Fix typing between sats connect and extension for providers * update sats-connect version --------- Co-authored-by: Mahmoud Aboelenein <[email protected]> --------- Co-authored-by: Victor Kirov <[email protected]>
jordankzf
pushed a commit
that referenced
this pull request
Jan 28, 2024
* init getAddress screen revamp * update ui * update btc address select request * update stx screen and add btcAddress to stacks connect response * ui fixes * minor fixes * disable account actions on connection requests * added icon borderRadius * remove debug log * Fix typing between sats connect and extension for providers (#768) * Fix typing between sats connect and extension for providers * update sats-connect version --------- Co-authored-by: Mahmoud Aboelenein <[email protected]> --------- Co-authored-by: Victor Kirov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR needs to be merged and published: secretkeylabs/sats-connect#59
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
With the XverseProvider object being types in sats-connect on the window object, the typing was not extendable and it resulted in typescript clashes.
🔄 Changes
The type was extracted into its own extendable interface in sats connect. This PR requires sats-connect tobe bumped and upgraded and the types are subsequently fixed with the interface correctly extended with the stacks provider.
This is a typing change, so there are no functional changes to test.
✅ Review checklist
Please ensure the following are true before merging: