Merge pull request #839 from secretkeylabs/chore/merge-main-to-public…

…-1730789211

merge-main-to-public

.env.example

@@ -1,3 +1,6 @@
+# Behavior
+SKIP_ANIMATION_WALLET_STARTUP=false;
+
 # Providers
 TRANSAC_API_KEY=
 MOON_PAY_API_KEY=

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,4 +1,5 @@
 # 🔘 PR Type
+
 What kind of change does this PR introduce?
 
 <!-- Please check the one that applies to this PR using "x". -->
@@ -13,22 +14,44 @@ What kind of change does this PR introduce?
 - [ ] Other... Please describe:
 
 # 📜 Background
+
 Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.
 
 Issue Link: #[issue_number]
 Context Link (if applicable):
 
 # 🔄 Changes
+
 Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.
 
 Impact:
+
 - Explain the broader impact of these changes.
 - How it improves performance, fixes bugs, adds functionality, etc.
 
+# 🧪 E2E Test Result
+
+Include a screenshot of the e2e test result.
+
+`Run E2E Tests`
+Our End-to-end (E2E) test suite is build with Playwright. To run the whole E2E test suite, run:
+`npm run e2etest`
+
+If you only want to run the smoke test suite, run
+`npm run e2etest:smoketest`
+
+If you want to run the e2e test in UI Mode:
+`npm run e2etest:ui`
+
+To generate test report, run:
+`npm run e2etest:report`
+
 # 🖼 Screenshot / 📹 Video
+
 Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.
 
 # ✅ Review checklist
+
 Please ensure the following are true before merging:
 
 - [ ] Code Style is consistent with the project guidelines.

.github/workflows/build-rc.yml

@@ -34,13 +34,14 @@ jobs:
           npm run knip
           npx eslint .
           npx tsc --noEmit
-          npm test
       - name: Build
         env:
           TRANSAC_API_KEY: ${{ secrets.TRANSAC_API_KEY }}
           MOON_PAY_API_KEY: ${{ secrets.MOON_PAY_API_KEY }}
           MIX_PANEL_TOKEN: ${{ secrets.MIX_PANEL_TOKEN }}
           MIX_PANEL_EXPLORE_APP_TOKEN: ${{ secrets.MIX_PANEL_EXPLORE_APP_TOKEN }}
+          SKIP_ANIMATION_WALLET_STARTUP: 'false'
+
         run: npm run build
       - name: Upload Archive
         uses: actions/upload-artifact@v3
@@ -131,7 +132,7 @@ jobs:
   publish-rc:
     # TODO also keep the develop PR description up to date
     if: ${{ github.base_ref == 'main' }}
-    needs: [UItest]
+    needs: build
     runs-on: ubuntu-latest
     permissions:
       contents: write

.github/workflows/build.yml

@@ -31,13 +31,13 @@ jobs:
           npm run knip
           npx eslint .
           npx tsc --noEmit
-          npm test
       - name: Build
         env:
           TRANSAC_API_KEY: ${{ secrets.TRANSAC_API_KEY }}
           MOON_PAY_API_KEY: ${{ secrets.MOON_PAY_API_KEY }}
           MIX_PANEL_TOKEN: ${{ secrets.MIX_PANEL_TOKEN }}
           MIX_PANEL_EXPLORE_APP_TOKEN: ${{ secrets.MIX_PANEL_EXPLORE_APP_TOKEN }}
+          SKIP_ANIMATION_WALLET_STARTUP: 'false'
         run: npm run build --if-present
       - name: Install Playwright Browsers
         run: npx playwright install chromium --with-deps

.github/workflows/playwright.yml

@@ -35,6 +35,7 @@ jobs:
           MOON_PAY_API_KEY: ${{ secrets.MOON_PAY_API_KEY }}
           MIX_PANEL_TOKEN: ${{ secrets.MIX_PANEL_TOKEN }}
           MIX_PANEL_EXPLORE_APP_TOKEN: ${{ secrets.MIX_PANEL_EXPLORE_APP_TOKEN }}
+          SKIP_ANIMATION_WALLET_STARTUP: 'true'
         run: npm run build --if-present
       - name: Upload Archive
         uses: actions/upload-artifact@v3

README.md

@@ -4,7 +4,7 @@
 
 ### Procedures
 
-1. Check if your [Node.js](https://nodejs.org/) version is >= **14**.
+1. Check if your [Node.js](https://nodejs.org/) version is >= **18**.
 2. Clone this repository.
 3. Make sure you're logged in to the @secretkeylabs scope on the GitHub NPM package registry. See the [Guide](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry#authenticating-with-a-personal-access-token)
    1. Create a GitHub personal access token (classic)
@@ -32,30 +32,3 @@ make or pull your local changes to xverse-core, then:
 cd ../xverse-core && npm i && npm run build:esm && \
 cd $OLDPWD && npm i --legacy-peer-deps @secretkeylabs/xverse-core@../xverse-core && npm start
 ```
-
-### Run E2E Tests
-
-Our End-to-end (E2E) test suite is build with Playwright.
-To run the whole E2E test suite, run:
-
-```
-npm run e2etest
-```
-
-If you only want to run the smoke test suite, run
-
-```
-npm run e2etest:smoketest
-```
-
-If you want to run the e2e test in UI Mode:
-
-```
-npm run e2etest:ui
-```
-
-To generate test report, run:
-
-```
-npm run e2etest:report
-```