Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use stacks poxAddressToTuple instead of custom mapping to convert address to tuple #379

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

fedeerbes
Copy link
Contributor

🔘 PR Type

  • Bugfix

📜 Background

This PR fixes an issue where address changed their format when converting to tuple

Issue Link: #ENG-3841

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • use poxAddressToTuple from @stacks/stacking and add deprecate tag to addressToVersionHashbyteTupleCV

Impact:

  • generation of unsigned delegation tx

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@fedeerbes fedeerbes self-assigned this Feb 29, 2024
Copy link
Contributor

Test this PR with npm i --save-exact @secretkeylabs/[email protected]

Copy link
Contributor

@abdulhaseeb4239 abdulhaseeb4239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fedeerbes fedeerbes merged commit 7ce2d04 into develop Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants