Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some small refactoring related to variables #374

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

dhriaznov
Copy link
Contributor

@dhriaznov dhriaznov commented Feb 19, 2024

🔘 PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

📜 Background

I noticed that we currently don't have the @typescript-eslint/no-unused-vars eslint rule enabled and that we still have the hardcoded the request timeout value instead of using the constant, so this PR is here to address those things.

Issue Link: #[issue_number]
Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • This PR enables the @typescript-eslint/no-unused-vars eslint rule to show the warnings for the unused vars/imports
  • It also changes the requests timeout value from 30000 to API_TIMEOUT_MILLI constant which has the same value

Impact:

  • This PR doesn't change any logic, it only improves the codebase and developer experience

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@dhriaznov dhriaznov self-assigned this Feb 19, 2024
Copy link
Contributor

Test this PR with npm i --save-exact @secretkeylabs/[email protected]

@dhriaznov dhriaznov marked this pull request as ready for review February 19, 2024 08:56
@dhriaznov dhriaznov requested review from victorkirov and removed request for jordankzf February 28, 2024 14:38
Copy link
Member

@victorkirov victorkirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌

@dhriaznov dhriaznov merged commit fbdd10c into develop Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants