Refactor transaction logic for ease of use

[victorkirov]

🔘 PR Type

What kind of change does this PR introduce?

• Enhancement

📜 Background

Minor changes to make the consolidated logic nicer to consume

🔄 Changes

Does this PR introduce a breaking change?

• Yes, Incompatible API changes
• No, Adds functionality (backwards compatible)
• No, Bug fixes (backwards compatible)

Changes:

• Mostly new types added and some renaming

Impact:

• Nothing is using this logic as yet, so no changes in extension/mobile needed

✅ Review checklist

Please ensure the following are true before merging:

• Code Style is consistent with the project guidelines.
• Code is readable and well-commented.
• No unnecessary or debugging code has been added.
• Security considerations have been taken into account.
• The change has been manually tested and works as expected.
• Breaking changes and their impacts have been considered and documented.
• Code does not introduce new technical debt or issues.

[teebszet]

I wonder if it's worth effort to make this PR backwards compatible? I remember our discussion with @fedeerbes around reducing breaking changes for when mobile is forced to bump core for certain functionality, but then required to refactor/fix for breakages

[victorkirov]

I wonder if it's worth effort to make this PR backwards compatible? I remember our discussion with @fedeerbes around reducing breaking changes for when mobile is forced to bump core for certain functionality, but then required to refactor/fix for breakages

This is backwards compatible, purely from the fact that this code is not used in mobile yet 😋

[victorkirov]

@m-aboelenein @teebszet ready for final review 🙏

[teebszet]

This is backwards compatible, purely from the fact that this code is not used in mobile yet 😋

cool. still technically a major version bump right?

[victorkirov]

This is backwards compatible, purely from the fact that this code is not used in mobile yet 😋

cool. still technically a major version bump right?

Yup, there are some interface changes on things that weren't used before.

[github-actions]

Test this PR with npm i --save-exact @secretkeylabs/[email protected]