Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove array.at usage as not supported in Native #215

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

victorkirov
Copy link
Member

@victorkirov victorkirov commented Aug 16, 2023

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix

📜 Background

Array.at was used in a function, but that syntax is not supported in React Native. This PR changes to using the alternative syntax.

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Impact:
The getOrdinalIdFromUtxo was failing in the mobile app. This is used in BTC recovery, which is currently not working as a result.

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@github-actions
Copy link
Contributor

Test this PR with npm i @secretkeylabs/[email protected]

@victorkirov victorkirov merged commit e0f6bfd into develop Aug 16, 2023
3 checks passed
@victorkirov victorkirov deleted the vk-fix-at branch August 16, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants