Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard against read properties of undefined errors in stx helper function #213

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

teebszet
Copy link
Member

🔘 PR Type

  • Bugfix

📜 Background

user reported extension crashing

Issue Link: https://linear.app/xverseapp/issue/ENG-2619/crash-on-loading
Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • guard against read properties of undefined errors in stx helper function

Impact:

  • called from web-extension when displaying STX transactions
  • also opened a PR for mobile to use this function

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@github-actions
Copy link
Contributor

Test this PR with npm i @secretkeylabs/[email protected]

@teebszet teebszet merged commit f1cd2da into develop Aug 15, 2023
3 checks passed
@teebszet teebszet deleted the tim/eng-2619-crash-on-loading branch August 15, 2023 00:56
@teebszet teebszet restored the tim/eng-2619-crash-on-loading branch October 4, 2023 03:37
@teebszet teebszet deleted the tim/eng-2619-crash-on-loading branch October 4, 2023 03:39
teebszet pushed a commit that referenced this pull request Oct 8, 2024
…functionality-from-ext-to-core

[ENG-5340] Export necessary functionality from the extension to core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants