-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use xord for ordinal detection #203
Merged
yknl
merged 12 commits into
develop
from
victor/eng-2552-use-xord-for-ordinal-recovery-detection
Aug 10, 2023
Merged
feat: use xord for ordinal detection #203
yknl
merged 12 commits into
develop
from
victor/eng-2552-use-xord-for-ordinal-recovery-detection
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorkirov
commented
Aug 9, 2023
@victorkirov there is a confict |
…into victor/eng-2552-use-xord-for-ordinal-recovery-detection
Thanks @DuskaT021, sorted it out |
|
yknl
approved these changes
Aug 10, 2023
yknl
reviewed
Aug 10, 2023
victorkirov
deleted the
victor/eng-2552-use-xord-for-ordinal-recovery-detection
branch
August 10, 2023 09:01
Merged
8 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
We currently use Hiro API to detect ordinals in UTXOs, but that API is sometimes behind or incorrect. This switches to using Xord.
🔄 Changes
Does this PR introduce a breaking change?
Changes:
We now use our own API for ordinal detection in UTXOs.
This will affect the ordinal recovery feature and ensuring that we don't spend ordinal UTXOs in BTC transactions.
Also added is the UTXO sort in the UTXO selection for a transaction. We now sort largest value to smallest and take from that list. This means that dust UTXOs would never be used for a transaction and it would result in a decrease in fees.
✅ Review checklist
Please ensure the following are true before merging: