Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
在jacobi.py的函数Rotation_Matrix中,之前的写法是用J = update_J(J, t_k, t_l, cos_values[i], sin_values[i], n)来实现将J[t_k][t_l]处的值设置为cos_values[i],其中t_k和t_l是秘密共享的。实际上t_k和t_l在执行过程中是明文的,可以直接用J=J.at[t_k,t_k].set(cos_values[i]),但是这样会报错 [libspu/kernel/hal/ring.cc:63] should not be here x=Value<1x1xSF32,s=0,0>, to=Pub2k。好像是cos_values[i]的类型有问题?