Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FQDN coding fix #4592

Closed
wants to merge 0 commits into from
Closed

FQDN coding fix #4592

wants to merge 0 commits into from

Conversation

ElKobano
Copy link
Contributor

IE_FQDN.fqdn coding fix

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (8e08cbf) to head (ff13476).

Files with missing lines Patch % Lines
scapy/contrib/gtp.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4592      +/-   ##
==========================================
- Coverage   81.62%   78.70%   -2.93%     
==========================================
  Files         358      333      -25     
  Lines       85652    80464    -5188     
==========================================
- Hits        69915    63330    -6585     
- Misses      15737    17134    +1397     
Files with missing lines Coverage Δ
scapy/contrib/gtp_v2.py 95.42% <ø> (ø)
scapy/contrib/gtp.py 91.47% <90.00%> (-0.07%) ⬇️

... and 284 files with indirect coverage changes

@gpotter2
Copy link
Member

Could you explain what the issue is? Thanks

@ElKobano
Copy link
Contributor Author

ElKobano commented Nov 23, 2024 via email

@gpotter2
Copy link
Member

Very sorry about the closure, I failed a rebase. See #4598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants