Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make sure ObjectPipe does not overwrite sensible defaut name by … #4532

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

phil777
Copy link
Contributor

@phil777 phil777 commented Sep 15, 2024

…Pipe class

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

fixes #xxx

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.58%. Comparing base (30b0398) to head (cc0e333).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4532   +/-   ##
=======================================
  Coverage   81.58%   81.58%           
=======================================
  Files         356      356           
  Lines       85292    85293    +1     
=======================================
+ Hits        69589    69590    +1     
  Misses      15703    15703           
Files with missing lines Coverage Δ
scapy/pipetool.py 87.03% <100.00%> (+0.02%) ⬆️

... and 3 files with indirect coverage changes

scapy/crc.py Outdated Show resolved Hide resolved
@gpotter2 gpotter2 enabled auto-merge (squash) September 24, 2024 19:59
@gpotter2 gpotter2 merged commit bf8652b into secdev:master Sep 24, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants