refactor: replace kubectl operation with k8s apiclient call #1745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Describe what this PR does / why we need it
RemoteApplyYaml
,RemoteCmdGetNetworkInterface
,RemoteCmdExistNetworkInterface
;k8s.Client
when executingkubectl
command, likekubectl delete node xxx
,kubectl get nodes
; After this pull request, there are still some kubectl command there, likekubectl drain
andkubectl uncordon
in upgrade operation. I found that k8s.Client has not containeddrain
anduncordon
command, and we should use another kubernetes/kubectl package to cover the above both.isHostName
intoisHostInExistingCluster
to be more readable.Does this pull request fix one issue?
none
Describe how you did it
none
Describe how to verify it
none
Special notes for reviews