treewide: Trim trailing spaces #2551
Merged
+214
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trimming trailing spaces is an accepted best practice. The practical benefit is that contributors with editors configured to always trim trailing spaces will not need to add an exception for seastar.
p12tic
force-pushed
the
trim-trailing-spaces
branch
from
3d9fe86
to
76912d0
Compare
|
@avikivity What do you think about adding trailing whitespace check to the CI? |
|
You are my hero for the day. |
I think it's a great idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trimming trailing spaces is an accepted best practice.
The practical benefit is that contributors with editors configured to always trim trailing spaces will not need to add an exception for seastar.
If maintainers want I could look into adding a CI action to prevent future inclusion of trailing spaces.