Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teardown steep for example benchamark #311

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Sep 6, 2024

closes #308

I got pointed thatcurrent faliture of benchamarks may be resolved by teardown steep.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.35%. Comparing base (69105e0) to head (d642d4b).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   63.08%   66.35%   +3.26%     
==========================================
  Files          19       19              
  Lines        2636     2684      +48     
==========================================
+ Hits         1663     1781     +118     
+ Misses        973      903      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucaMarconato
Copy link
Member

Thanks @Czaki!

@LucaMarconato LucaMarconato merged commit 7d49c23 into scverse:main Oct 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-bot] Benchmark tests failing
2 participants