Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read_zarr for consolidated metadata and use directly on zarr.Group #1057

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Jul 14, 2023

@ivirshup ivirshup added this to the 0.9.2 milestone Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1057 (d7ace2d) into main (b118ba4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   84.12%   84.13%           
=======================================
  Files          33       33           
  Lines        4731     4733    +2     
=======================================
+ Hits         3980     3982    +2     
  Misses        751      751           
Impacted Files Coverage Δ
anndata/_io/zarr.py 83.95% <100.00%> (+0.40%) ⬆️

Copy link
Member

@LucaMarconato LucaMarconato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for the quick fix!

@ivirshup ivirshup merged commit 510a233 into scverse:main Jul 14, 2023
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Jul 14, 2023
ivirshup added a commit that referenced this pull request Jul 17, 2023
…directly on zarr.Group (#1058)

Co-authored-by: Isaac Virshup <[email protected]>
berombau added a commit to berombau/spatialdata that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty AnnData returned when reading Zarr from S3
2 participants