Feat: xml validation #660
Draft
Feat: xml validation #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Havia problema da leitura das listas por conta da utilização de "-" e "." na composição dos nomes
packtools/xml_validation.py
Outdated
| def get_data(filename, key, sps_version=None): | ||
| sps_version = sps_version or "default" | ||
| # Reads contents with UTF-8 encoding and returns str. | ||
| content = files(f'packtools.sps.sps_versions.{sps_version}').joinpath(f"{filename}.json").read_text() |
There was a problem hiding this comment.
def get_data(filename, key, sps_version=None):
sps_version = sps_version or "default"
# Reads contents with UTF-8 encoding and returns str.
content = (
files(f"packtools.sps.sps_versions")
.joinpath(f"{sps_version}")
.joinpath(f"{filename}.json")
.read_text()
)
x = " ".join(content.split())
fixed = x.replace(", ]", "]").replace(", }", "}")
data = json.loads(fixed)
return data[key]There was a problem hiding this comment.
OK, @robertatakenaka
| @@ -0,0 +1,41 @@ | |||
| { | |||
There was a problem hiding this comment.
@Rossi-Luciano move todos os json de volta para sps-1.9 e sps-1.10
There was a problem hiding this comment.
OK, @robertatakenaka
| parent_id=None, | ||
| parent_article_type=self.xmltree.get("article-type"), | ||
| parent_lang=self.xmltree.get("{http://www.w3.org/XML/1998/namespace}lang"), | ||
| item="journal-meta", |
There was a problem hiding this comment.
item="journal-id"
sub-item="@journal-id-type='publisher-id'"
There was a problem hiding this comment.
OK, @robertatakenaka
| @@ -359,7 +364,7 @@ def validate(self, expected_values): | |||
| nlm_ta = JournalIdValidation(self.xmltree) | |||
|
|
|||
| resp_journal_meta = list(issn.validate_issn(expected_values['issns'])) + \ | |||
| acronym.acronym_validation(expected_values['acronym']) + \ | |||
| list(acronym.acronym_validation(expected_values['acronym'])) + \ | |||
There was a problem hiding this comment.
@Rossi-Luciano trocar este trecho por yield ou yield from. Talvez até eliminaria este método
There was a problem hiding this comment.
OK, @robertatakenaka
packtools/xml_validation.py
Outdated
Comment on lines
134
to
135
| sps_version = sps_version.replace("-", "_") | ||
| sps_version = sps_version.replace(".", "_") |
There was a problem hiding this comment.
@Rossi-Luciano remover;
sps_version = sps_version.replace("-", "_")
sps_version = sps_version.replace(".", "_")There was a problem hiding this comment.
OK, @robertatakenaka
robertatakenaka
requested changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Este Pull Request adiciona funcionalidades para a validação de arquivos XML e a geração de relatórios em formato CSV. Especificamente, ele inclui:
get_xml_tree: Lê o conteúdo de um arquivo XML e retorna sua árvore XML.get_data: Recupera dados de arquivos JSON, utilizados como referência para validações.create_report: Cria um relatório de validação em CSV a partir de um arquivo XML.save_csv: Salva os resultados da validação em um arquivo CSV.validate_xml_content: Executa várias validações em um arquivo XML, agrupando-as por categorias como atributos do artigo, idiomas, tipos de artigo, etc.Essas adições facilitam a verificação e análise de arquivos XML de acordo com critérios pré-definidos, melhorando a qualidade e conformidade dos dados processados.
Onde a revisão poderia começar?
Por commit.
Como este poderia ser testado manualmente?
Execução:
Execute o script com o seguintes comando:
python3 packtools/xml_validation.py -i packtools/xml_validation/xmls/ -o packtools/xml_validation/reports/Verificação:
Verifique os arquivos CSV gerados na pasta de saída para garantir que os resultados das validações estão corretos e completos.
Exemplo do CSV gerado:
Screenshots
NA
Quais são tickets relevantes?
NA
Referências
NA