-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[markup xml] Resolve problema de "mismatched" tags por conta das tags de estilo do Word #3234
Open
robertatakenaka
wants to merge
17
commits into
scieloorg:master
Choose a base branch
from
robertatakenaka:40097_tk3201_mismatched_style_tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[markup xml] Resolve problema de "mismatched" tags por conta das tags de estilo do Word #3234
robertatakenaka
wants to merge
17
commits into
scieloorg:master
from
robertatakenaka:40097_tk3201_mismatched_style_tags
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Para primeiro passo, converte as tags "xml" em tags "sgml" de forma que sejam ignoradas ao carregar o xml em formato de árvore Para segundo passo, verifica cada trecho node.text e tenta restaurar as tags de estilo, ou seja, convertendo de "sgml" para "xml" e verificando se o XML segue bem formado, caso contrário não restaura as tags dos trechos. As tags que causam um XML mal formado ficam como "sgml" para nos próximos passos serem tratadas. Cria testes para a classe
Tenta usar uma outra estratégia
…es nas extremidades
…es nas extremidades até que não exista necessidade
Trocar "retry" por "fix"
…das tags de estilo
…yle_tags_in_node_tail e seus respectivos conteúdo substituem as suas respectivas chamadas
…iar `_check_content` e faz outros ajustes em `_update_node_text` e `_update_node_tail` Elimina `_fix()` e seu conteúdo, ou seja, as chamadas a `_fix_inserting_tags_at_the_extremities` e `_fix_loading_xml_with_recover_true`, passam a ser feitas dentro de `_restore_matched_style_tags_in_node_tails` e `_restore_matched_style_tags_in_node_texts`
Desmarca as tags de estilos corrigidas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Os XML gerados a partir do documento marcado pode estar quebrado por conta das tags de estilos que são geradas a partir dos estilos do Word e não a partir das etiquetas dos elementos do Markup.
Onde a revisão poderia começar?
Por commits
Como este poderia ser testado manualmente?
TODO...
Algum cenário de contexto que queira dar?
n/a
Screenshots
TODO
Quais são tickets relevantes?
#3201
Referências
n/a