BinaryCIF Import Implementation #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarrettSJohnson
changed the title
TstewDev
approved these changes
May 29, 2024
| @test_utils.requires_version("3.0") | ||
| def test_bcif(): | ||
| cmd.load(test_utils.datafile("115d.bcif.gz")) | ||
| assert cmd.count_atoms() == 407 |
There was a problem hiding this comment.
Are there any other properties worth checking? Seems sufficient for just ensuring the structure is loaded in.
There was a problem hiding this comment.
Added tests with cif_get_array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Announced via RSCB news.
"
From July 2024 the PDB file archive will not be offered in the compressed MMTF format anymore. Users are strongly encouraged to switch to the BinaryCIF format, which has been available since 2020. Details on how to access BinaryCIF (BCIF) data files for the entire PDB archive are available here.
"
Implementation of Reading BinaryCIF #329
Able to fetch various models from the pdb via
fetch XXX, type=bcifTests: