Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eyetracking utilization #523

Open
wants to merge 67 commits into
base: main
Choose a base branch
from
Open

Eyetracking utilization #523

wants to merge 67 commits into from

Conversation

smlpt
Copy link
Contributor

@smlpt smlpt commented Jul 6, 2023

Changes made by Ruoshan to implement a bridge for Mastodon tracking to Sciview, as well as utilize eye tracking in Sciview.

RuoshanLan and others added 30 commits August 2, 2021 10:42
# Conflicts:
#	build.gradle.kts
#	gradle/wrapper/gradle-wrapper.jar
#	gradle/wrapper/gradle-wrapper.properties
#	settings.gradle.kts
@kephale
Copy link
Member

kephale commented Oct 10, 2024

Just checking how you're doing on this @smlpt!

It looks pretty merge friendly, but I'm curious if there is anything else you need on the sciview side?

@smlpt
Copy link
Contributor Author

smlpt commented Oct 11, 2024

Just checking how you're doing on this @smlpt!

It looks pretty merge friendly, but I'm curious if there is anything else you need on the sciview side?

I am currently in the process of refactoring many of the tracking classes, because they were all created as command style classes, making it tedious to call them from code (I couldn't really call any member function except for run()). So I'm going to extract their functionality into separate classes, and then the Demo-named classes simply exist for the command purpose (like I already did in 886997a for the EyeTracking class).
I also consolidated most of their functionality into a base class, because several different classes (EyeTrackingDemo, VRControllerTrackingDemo, VRHeadsetTrackingDemo, Test) all shared large chunks of more or less identical code.

So to answer your question: this branch turned into an active construction site again, and I may have to refine a few more things related to the tracking before we can merge it.
Or do you think its better to merge a basic (working) version of the branch first, and then keep working on it in a new branch?

I would also appreciate if this branch could be merged into scenery soon™, in case I need to add other stuff to scenery.

@smlpt
Copy link
Contributor Author

smlpt commented Oct 11, 2024

This should now bring some order into the naming scheme.
NB: The CI is still failing because I am using the "centered" keyword when showing camera messages, and this feature isn't part of a new scenery release yet (but only exists in scenery main, which I include locally).
(Well and also the grid traversal volume sampling from the corresponding scenery branch)

@smlpt
Copy link
Contributor Author

smlpt commented Nov 19, 2024

I cleaned up the files, the PR is now ready for review. The CI fails because we can't use local scenery with it, and there's a scenery function that was updated in main and that didn't make it into a new release yet.
A few classes were mostly copied from Ruoshan and then cleaned up; I didn't have the time yet to test their functionality. I will probably change or remove those classes in the future: VRHeadsetTracking, TrackingTest, VRControllerTracking.

@smlpt smlpt marked this pull request as ready for review November 19, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants