Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drawer #4492

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: drawer #4492

wants to merge 4 commits into from

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Feature

Summarise concisely:

What is expected?

New component <Drawer />

@lisalupi lisalupi added the enhancement New feature or request label Nov 22, 2024
@lisalupi lisalupi requested a review from a team November 22, 2024 11:13
@lisalupi lisalupi self-assigned this Nov 22, 2024
@lisalupi lisalupi requested review from matthprost and removed request for a team November 22, 2024 11:13
Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 54b9b86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 89.70588% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.43%. Comparing base (e49711a) to head (54b9b86).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../ui/src/components/Drawer/__tests__/index.test.tsx 89.32% 11 Missing ⚠️
packages/ui/src/components/Drawer/index.tsx 90.90% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4492      +/-   ##
==========================================
+ Coverage   86.80%   87.43%   +0.62%     
==========================================
  Files         326      336      +10     
  Lines       11933    12737     +804     
  Branches     3311     3463     +152     
==========================================
+ Hits        10358    11136     +778     
- Misses       1575     1601      +26     
Files with missing lines Coverage Δ
packages/ui/src/components/Drawer/index.tsx 90.90% <90.90%> (ø)
.../ui/src/components/Drawer/__tests__/index.test.tsx 89.32% <89.32%> (ø)

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49711a...54b9b86. Read the comment docs.

packages/ui/src/components/Drawer/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Drawer/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/Drawer/style.css Show resolved Hide resolved
packages/ui/src/components/Drawer/style.css Show resolved Hide resolved
packages/ui/src/components/Drawer/index.tsx Outdated Show resolved Hide resolved
@mhervouet
Copy link

mhervouet commented Nov 25, 2024

Need to fix header spacing + divider takes all the drawer width

Capture d'écran 2024-11-25 à 15 17 09 PM
Capture d'écran 2024-11-25 à 15 16 52 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants