Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(estimate-cost): remove z-index from Overlay #3544

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix(estimate-cost): remove z-index from Overlay #3544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stale-cooks-boil.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ultraviolet/plus": patch
---

remove z-index from EstimateCost Overlay component
1 change: 0 additions & 1 deletion packages/plus/src/components/EstimateCost/OverlayComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import type { Units } from './types'

const OverlayContainer = styled.div<{ inView?: boolean }>`
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: ${({ inView }) => (inView ? -120 : 0)}px;
Expand Down
30 changes: 12 additions & 18 deletions packages/plus/src/components/EstimateCost/__tests__/__snapshots__/Item.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ exports[`EstimateCost - Item render with labelTextVariant 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -843,7 +842,7 @@ exports[`EstimateCost - Item render with labelTextVariant 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -1194,9 +1193,8 @@ exports[`EstimateCost - Item render with noPrice and noBorder 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -1988,7 +1986,7 @@ exports[`EstimateCost - Item render with noPrice and noBorder 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -2333,9 +2331,8 @@ exports[`EstimateCost - Item render with notice 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -3152,7 +3149,7 @@ exports[`EstimateCost - Item render with notice 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -3513,9 +3510,8 @@ exports[`EstimateCost - Item render with priceText 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -4320,7 +4316,7 @@ exports[`EstimateCost - Item render with priceText 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -4671,9 +4667,8 @@ exports[`EstimateCost - Item render with tabulation 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -5478,7 +5473,7 @@ exports[`EstimateCost - Item render with tabulation 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -5829,9 +5824,8 @@ exports[`EstimateCost - Item render with tooltipInfo 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -6657,7 +6651,7 @@ exports[`EstimateCost - Item render with tooltipInfo 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down
5 changes: 2 additions & 3 deletions packages/plus/src/components/EstimateCost/__tests__/__snapshots__/Region.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ exports[`EstimateCost - Region render region component 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -837,7 +836,7 @@ exports[`EstimateCost - Region render region component 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down
60 changes: 24 additions & 36 deletions packages/plus/src/components/EstimateCost/__tests__/__snapshots__/Regular.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ exports[`EstimateCost - Regular Item render basic props 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -808,7 +807,7 @@ exports[`EstimateCost - Regular Item render basic props 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -1159,9 +1158,8 @@ exports[`EstimateCost - Regular Item render basic props with is not defined 1`]
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -1912,7 +1910,7 @@ exports[`EstimateCost - Regular Item render basic props with is not defined 1`]
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -2255,9 +2253,8 @@ exports[`EstimateCost - Regular Item render basic props with long fractions digi
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -3038,7 +3035,7 @@ exports[`EstimateCost - Regular Item render basic props with long fractions digi
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -3389,9 +3386,8 @@ exports[`EstimateCost - Regular Item render basic props with maxPrice 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -4184,7 +4180,7 @@ exports[`EstimateCost - Regular Item render basic props with maxPrice 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -4540,9 +4536,8 @@ exports[`EstimateCost - Regular Item render basic props with maxPrice and longFr
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -5335,7 +5330,7 @@ exports[`EstimateCost - Regular Item render basic props with maxPrice and longFr
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -5691,9 +5686,8 @@ exports[`EstimateCost - Regular Item render basic props with overlay 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -6569,7 +6563,7 @@ exports[`EstimateCost - Regular Item render basic props with overlay 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -7025,9 +7019,8 @@ exports[`EstimateCost - Regular Item render basic props with overlay beta 1`] =
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -7947,7 +7940,7 @@ exports[`EstimateCost - Regular Item render basic props with overlay beta 1`] =
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -8345,9 +8338,8 @@ exports[`EstimateCost - Regular Item render basic props with sublabel 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -9142,7 +9134,7 @@ exports[`EstimateCost - Regular Item render basic props with sublabel 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -9498,9 +9490,8 @@ exports[`EstimateCost - Regular Item render basic props with textNotDefined 1`]
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -10281,7 +10272,7 @@ exports[`EstimateCost - Regular Item render basic props with textNotDefined 1`]
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -10632,9 +10623,8 @@ exports[`EstimateCost - Regular Item render basic with ellipsis 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -11445,7 +11435,7 @@ exports[`EstimateCost - Regular Item render basic with ellipsis 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -11810,9 +11800,8 @@ exports[`EstimateCost - Regular Item render with alert 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -12720,7 +12709,7 @@ exports[`EstimateCost - Regular Item render with alert 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down Expand Up @@ -13105,9 +13094,8 @@ exports[`EstimateCost - Regular Item render with isDisabledOnOverlay 1`] = `
flex-wrap: nowrap;
}

.css-1twbxpf-OverlayContainer {
.css-1d9gk6m-OverlayContainer {
position: fixed;
z-index: 999;
left: 0;
right: 0;
bottom: 0px;
Expand Down Expand Up @@ -13873,7 +13861,7 @@ exports[`EstimateCost - Regular Item render with isDisabledOnOverlay 1`] = `
class="css-1t7ypwa ehpbis70"
>
<div
class="css-1twbxpf-OverlayContainer e1p62vjs2"
class="css-1d9gk6m-OverlayContainer e1p62vjs2"
data-testid="summary-overlay"
>
<ul
Expand Down
Loading
Loading