Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s): rework kubeconfig handling #4137

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jtherin
Copy link
Member

@jtherin jtherin commented Sep 18, 2024

No description provided.

@github-actions github-actions bot added the k8s Kubernetes Kapsule issues, bugs and feature requests label Sep 18, 2024
@jtherin jtherin force-pushed the k8skubeconfig branch 5 times, most recently from f967445 to 710551c Compare September 19, 2024 08:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 55.24862% with 162 lines in your changes missing coverage. Please review.

Project coverage is 70.89%. Comparing base (5bf53e0) to head (07ffbaa).
Report is 344 commits behind head on master.

Files with missing lines Patch % Lines
...nal/namespaces/k8s/v1/custom_kubeconfig_helpers.go 53.20% 56 Missing and 17 partials ⚠️
...nal/namespaces/k8s/v1/custom_kubeconfig_install.go 39.28% 47 Missing and 4 partials ⚠️
...nternal/namespaces/k8s/v1/custom_kubeconfig_get.go 70.73% 22 Missing and 2 partials ⚠️
...l/namespaces/k8s/v1/custom_kubeconfig_uninstall.go 60.86% 6 Missing and 3 partials ⚠️
internal/namespaces/k8s/v1/custom.go 78.57% 3 Missing ⚠️
...ternal/namespaces/k8s/v1/custom_execcredentials.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4137      +/-   ##
==========================================
- Coverage   75.45%   70.89%   -4.57%     
==========================================
  Files         202      294      +92     
  Lines       44323    66263   +21940     
==========================================
+ Hits        33444    46975   +13531     
- Misses       9653    17625    +7972     
- Partials     1226     1663     +437     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

AfterFunc: deleteCluster("Cluster"),
}))

// t.Run("copy-token", core.Test(&core.TestConfig{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this code commented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid possible leaking of a token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants