Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scalardb-analytics-spark-sample to support 3.14 #75

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Update scalardb-analytics-spark-sample to support 3.14 #75

merged 3 commits into from
Nov 21, 2024
+135 −150

Conversation

choplin
Copy link
Contributor

@choplin choplin commented Nov 20, 2024

Description

This PR updates scalardb-analytics-spark-sample for the 3.14 release.

Related issues and/or PRs

Changes made

  • We now launch PostgreSQL, MySQL and Cassandra. We use ScalarDB to manage MySQL and Cassandra. PostgreSQL is used independently.
    • This is intended to demonstrate the virtualization feature introduced in 3.14.
  • Update the depending ScalarDB version to 3.14
  • Update Gradle version

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

None

@choplin choplin self-assigned this Nov 20, 2024
@choplin choplin force-pushed the update_scalardb_analytics_spark_sample branch 2 times, most recently from 98acd70 to c7abd6b Compare November 20, 2024 12:22
@choplin choplin force-pushed the update_scalardb_analytics_spark_sample branch from c7abd6b to 67c5f6d Compare November 20, 2024 12:24
brfrn169
brfrn169 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment. Other than that, LGTM! Thank you!

scalardb-analytics-spark-sample/sample-data-loader/build.gradle.kts Outdated Show resolved Hide resolved
@choplin
Copy link
Contributor Author

choplin commented Nov 20, 2024

BTW, I noticed that many unrelated Actions run. It would be worth setting more strict filtering.

feeblefakie
feeblefakie approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

komamitsu
komamitsu approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@choplin choplin merged commit 5694c32 into main Nov 21, 2024
32 checks passed
@choplin choplin deleted the update_scalardb_analytics_spark_sample branch November 21, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@brfrn169 brfrn169 brfrn169 approved these changes

@komamitsu komamitsu komamitsu approved these changes

Assignees

@choplin choplin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@choplin @komamitsu @brfrn169 @feeblefakie