Replace deprecated Gradle/ScalarDB features #74

KodaiD · 2024-11-11T02:29:06Z

Description

This PR replaces deprecated Gradle/ScalarDB features to suppress warning messages.

The sample applications of ScalarDB use some deprecated Gradle features and put API of ScalarDB. Due to these reasons, multiple warning messages are displayed when the sample application is executed, which is annoying to users.

So this PR replaces all deprecated Gradle features and replaces put API of ScalarDB with update/insert.

Related issues and/or PRs

N/A

Changes made

Replace deprecated Gradle features.
Replace put API of ScalarDB with update/insert.

Checklist

I have commented my code, particularly in hard-to-understand areas.
I have updated the documentation to reflect the changes.
Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
Tests (unit, integration, etc.) have been added for the changes.
My changes generate no new warnings.
Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

KodaiD · 2024-11-11T02:31:38Z

microservice-transaction-sample/client/build.gradle

 application {
-    mainClassName = 'sample.client.Client'
+    mainClass = 'sample.client.Client'
 }


This fix suppress the following warning message:

The org.gradle.api.plugins.ApplicationPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.5/userguide/upgrading_version_8.html#application_convention_deprecation

KodaiD · 2024-11-11T02:32:31Z

microservice-transaction-sample/client/build.gradle

-archivesBaseName = "sample-order-service"
+base {
+    archivesName = "sample-order-service"
+}


This fix suppress the following warning message:

The org.gradle.api.plugins.BasePluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.5/userguide/upgrading_version_8.html#base_convention_deprecation

KodaiD · 2024-11-11T02:33:09Z

microservice-transaction-sample/client/build.gradle

-sourceCompatibility = 1.8
-targetCompatibility = 1.8
+java {
+    toolchain {
+        languageVersion = JavaLanguageVersion.of(8)
+    }
+}


This fix suppress the following warning message:

The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.5/userguide/upgrading_version_8.html#java_convention_deprecation

KodaiD · 2024-11-11T02:36:27Z

microservice-transaction-sample/rpc/build.gradle

-    id 'com.google.protobuf' version '0.9.1'
+    id 'com.google.protobuf' version '0.9.4'


To suppress the following warning message, com.google.protobuf must be upgraded.

The Provider.forUseAtConfigurationTime method has been deprecated. This is scheduled to be removed in Gradle 9.0. Simply remove the call. Consult the upgrading guide for further information: https://docs.gradle.org/8.5/userguide/upgrading_version_7.html#for_use_at_configuration_time_deprecation

KodaiD · 2024-11-11T02:40:00Z

microservice-transaction-sample/rpc/build.gradle

@@ -20,16 +20,40 @@ protobuf {
    generateProtoTasks {
        all()*.plugins { grpc {} }
    }
-    generatedFilesBaseDir = "$projectDir/src"


generatedFilesBaseDir is deprecated in com.google.protobuf v0.9.2- (ref. google/protobuf-gradle-plugin#636).

KodaiD · 2024-11-11T02:41:58Z

microservice-transaction-sample/rpc/build.gradle

+// Task copyGeneratedProtoToSrc copies the generated .java files into src directory
+task copyGeneratedProtoToSrc(type: Copy) {
+    description 'Copies generated Protocol Buffer classes to src/main/java/sample/rpc'
+    dependsOn generateProto
+    from "$buildDir/generated/source/proto/main/java/sample/rpc"
+    into "$projectDir/src/main/java/sample/rpc"
+    duplicatesStrategy = DuplicatesStrategy.INCLUDE
+}


Since generatedFilesBaseDir is deprecated, we need to implement a similar functionality using copy.

KodaiD · 2024-11-11T02:45:28Z

microservice-transaction-sample/rpc/build.gradle

+// Task deleteBuildMainJava deletes the generated .java files in build directory
+task deleteBuildMainJava(type: Delete) {
+    dependsOn copyGeneratedProtoToSrc
+    delete fileTree(dir: "$buildDir/generated/source/proto/main/java/sample/rpc")
+}


Before running the compileJava task, the files under src/main/java must be deleted, otherwise we will get duplicate class errors like:

xxx/scalardb-samples/microservice-transaction-sample/rpc/build/generated/source/proto/main/java/sample/rpc/CommitRequest.java:9: エラー: クラスsample.rpc.CommitRequestが重複しています public final class CommitRequest extends

This task seems to delete only the generated protobuf files in the build directory, but the current task name might look to delete more. How about adding GeneratedProtobuf or something to the task name?

@komamitsu Thanks for reviewing! I applied your suggestion in 8427a0d. PTAL!

KodaiD · 2024-11-11T02:48:57Z

scalardb-kotlin-sample/build.gradle.kts

-java {
-    sourceCompatibility = JavaVersion.VERSION_1_8
-    targetCompatibility = JavaVersion.VERSION_1_8


Because there is kotlin { jvmToolchain(8) }, this setting seems to be unnecessary.

KodaiD · 2024-11-11T05:03:29Z

I've confirmed that no warnings appear when executing ./gradlew build --warning-mode all.

scalardb-samples on  fix-to-remove-warnings [!?] took 2s
❯ ./check_build.sh
Processing directory: microservice-transaction-sample
./gradlew build --warning-mode all

BUILD SUCCESSFUL in 828ms
29 actionable tasks: 2 executed, 27 up-to-date
Processing directory: multi-storage-transaction-sample
./gradlew build --warning-mode all

BUILD SUCCESSFUL in 2s
5 actionable tasks: 5 executed
Processing directory: scalardb-kotlin-sample
./gradlew build --warning-mode all

BUILD SUCCESSFUL in 2s
5 actionable tasks: 5 executed
Processing directory: scalardb-sample
./gradlew build --warning-mode all

BUILD SUCCESSFUL in 2s
5 actionable tasks: 5 executed
Processing directory: scalardb-sql-jdbc-sample
./gradlew build --warning-mode all

BUILD SUCCESSFUL in 3s
5 actionable tasks: 5 executed
Processing directory: spring-data-microservice-transaction-sample
./gradlew build --warning-mode all

BUILD SUCCESSFUL in 616ms
29 actionable tasks: 2 executed, 27 up-to-date
Processing directory: spring-data-multi-storage-transaction-sample
./gradlew build --warning-mode all

BUILD SUCCESSFUL in 3s
6 actionable tasks: 6 executed
Processing directory: spring-data-sample
./gradlew build --warning-mode all

BUILD SUCCESSFUL in 3s
6 actionable tasks: 6 executed

feeblefakie

LGTM! Thank you!

brfrn169

LGTM! Thank you!

kota2and3kan

Thank you for the updates!
Overall looks good to me, but I left minor comments.
Please take a look when you have time! 🙇‍♂️

...ervice-transaction-sample/customer-service/src/main/java/sample/customer/model/Customer.java

microservice-transaction-sample/order-service/src/main/java/sample/order/model/Item.java

microservice-transaction-sample/order-service/src/main/java/sample/order/model/Order.java

microservice-transaction-sample/order-service/src/main/java/sample/order/model/Statement.java

Torch3333

LGTM, thank you!

komamitsu

LGTM, thank you!

kota2and3kan

LGTM! Thank you!

KodaiD added 2 commits November 7, 2024 19:05

Replace deprecated Gradle features

bb44f06

Replace deprecated put with update and insert

d686570

KodaiD added the improvement label Nov 11, 2024

KodaiD self-assigned this Nov 11, 2024

KodaiD commented Nov 11, 2024

View reviewed changes

Replace deprecated put with update and upsert in the Kotilin sample

17c6dfa

KodaiD requested review from komamitsu, brfrn169, feeblefakie, Torch3333 and kota2and3kan November 11, 2024 05:05

feeblefakie approved these changes Nov 11, 2024

View reviewed changes

brfrn169 approved these changes Nov 11, 2024

View reviewed changes

kota2and3kan reviewed Nov 12, 2024

View reviewed changes

Change function names from put to insert

789b3c2

KodaiD requested a review from kota2and3kan November 12, 2024 04:19

Torch3333 approved these changes Nov 12, 2024

View reviewed changes

Renamed the delete task

8427a0d

komamitsu approved these changes Nov 13, 2024

View reviewed changes

kota2and3kan approved these changes Nov 14, 2024

View reviewed changes

KodaiD merged commit bdedc82 into main Nov 20, 2024
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace deprecated Gradle/ScalarDB features #74

Replace deprecated Gradle/ScalarDB features #74

KodaiD commented Nov 11, 2024

KodaiD Nov 11, 2024

KodaiD Nov 11, 2024

KodaiD Nov 11, 2024

KodaiD Nov 11, 2024

KodaiD Nov 11, 2024

KodaiD Nov 11, 2024

KodaiD Nov 11, 2024

komamitsu Nov 13, 2024

KodaiD Nov 13, 2024

KodaiD Nov 11, 2024

KodaiD commented Nov 11, 2024

feeblefakie left a comment

brfrn169 left a comment

kota2and3kan left a comment

Torch3333 left a comment

komamitsu left a comment

kota2and3kan left a comment

		id 'com.google.protobuf' version '0.9.1'
		id 'com.google.protobuf' version '0.9.4'

Replace deprecated Gradle/ScalarDB features #74

Replace deprecated Gradle/ScalarDB features #74

Conversation

KodaiD commented Nov 11, 2024

Description

Related issues and/or PRs

Changes made

Checklist

Additional notes (optional)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KodaiD commented Nov 11, 2024

feeblefakie left a comment

Choose a reason for hiding this comment

brfrn169 left a comment

Choose a reason for hiding this comment

kota2and3kan left a comment

Choose a reason for hiding this comment

Torch3333 left a comment

Choose a reason for hiding this comment

komamitsu left a comment

Choose a reason for hiding this comment

kota2and3kan left a comment

Choose a reason for hiding this comment