[ScalarDB .NET Client] Add microservice transactions sample with Shared-cluster pattern with LINQ #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed-cluster pattern with LINQ
Dima-X
requested review from
a team,
komamitsu,
brfrn169,
feeblefakie,
Torch3333,
kota2and3kan and
josh-wong
and removed request for
a team
josh-wong
approved these changes
Sep 30, 2024
...ervice-transactions-sample-with-shared-cluster-with-linq/Client/Commands/GetOrdersCommand.cs
Outdated
Show resolved
Hide resolved
...service-transactions-sample-with-shared-cluster-with-linq/CustomerService/CustomerService.cs
Outdated
Show resolved
Hide resolved
dotnet/microservice-transactions-sample-with-shared-cluster-with-linq/DataLoader/Program.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Wong <[email protected]>
komamitsu
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
LGTM! 👍
I compared this and https://github.com/scalar-labs/scalardb-cluster-dotnet-client-sdk/pull/110 that I've already approved. There is no significant diff between them.
BTW, this PR adds a top-level directory dotnet to group sample applications by language. But, grouping by the type of sample applications (e.g., multi-storage) could be another option. We might need some discussion on it.
feeblefakie
approved these changes
Oct 1, 2024
feeblefakie
reviewed
Oct 1, 2024
kota2and3kan
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
LGTM! Thank you!
FYI: I was able to run this sample application in my local environment based on the new document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves a microservice transactions sample with the shared-cluster pattern with LINQ from scalardb-cluster-dotnet-client-sdk .
This is a .NET version of #64.
The sample made in a similar manner to it’s Java counterpart, but it has 2 additional projects:
Related issues and/or PRs
https://github.com/scalar-labs/docs-internal-scalardb/pull/456
https://github.com/scalar-labs/scalardb-cluster-dotnet-client-sdk/pull/110#issuecomment-2240906449
Changes made
dotnet/microservice-transactions-sample-with-shared-cluster-with-linq.gitignoreChecklist
Additional notes (optional)
The main difference with scalardb-cluster-dotnet-client-sdk:
3.13version ofScalarDB.Clientfrom NuGetdocker-compose.yml:scalardb-cluster-node-byol-premium:3.13.0is referenced