improvement: if no binary version in jar path try using build target info #6698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also try to check if there tasty files, but this is already a good improvement |
That's a better way to do this (though tasty files won't be in sources, so we have to map source jars to dep jars). |
…scala version for source jar
kasiaMarek
force-pushed
the
jar-scala-version
branch
from
ddd69d3
to
087940c
Compare
tgodzik
approved these changes
Aug 26, 2024
| @@ -434,10 +434,14 @@ final class BuildTargets private ( | |||
| * @return path to the source jar for that jar | |||
| */ | |||
| private def sourceJarPathFallback( | |||
| sourceJarPath: AbsolutePath | |||
| sourceJarPath: AbsolutePath, | |||
There was a problem hiding this comment.
We would probably need to rename the parameters and the method
|
@tgodzik @kasiaMarek what's holding up these changes? |
I'm afraid, I am. I need to address Tomek's review comment and it can be merged after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For jars if no scala version included in the path, fallback to using scala version from build target before defaulting to "2.13".
resolves: #6693