Scala 3/sbt 2 prep #259
Merged
Scala 3/sbt 2 prep #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyAutrey
commented
Oct 17, 2024
| import java.io.File | ||
|
|
||
| package object web { | ||
|
|
||
| /** | ||
| * Describes a string path relative to a base directory. | ||
| */ | ||
| type PathMapping = (File, String) | ||
| type PathMapping = (FileRef, String) |
There was a problem hiding this comment.
This is necessary because Keys.mappings changed types in sbt 2. The type change creates significant type collisions in keys, mapping logic, and deduplicators.
Almost all of the type changes and FileConverter additions in SbtWeb.scala stem from this change.
mkurz
reviewed
Oct 17, 2024
mkurz
requested changes
Oct 17, 2024
Includes: * Add compatibility shims for colliding types * Switch to slash format in sbt files * Fix various warnings, errors when compiling in scala3 mode
BillyAutrey
force-pushed
the
scala-3-compat-fixes
branch
from
b939cb3
to
c915b62
Compare
Done and done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of scala 3 compatibility fixes. 1 of a series of PRs for sbt 2 compatibility.
+format.scalafmt-native-action@v4-Xsource:3in Scala 2.12 mode.Note: This does not actually activate cross-builds. They won't work, still need to fix scripted tests.
Towards #255