Fix curve child listOfElements #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In libsbml, the list is called a ListOfCurveElements, but in SBML proper, it's just 'listOfElements'. It gets written out as the latter, but was required to be the former when read in, which meant that nothing libsbml wrote could be read back in.
fbergmann
approved these changes
Nov 22, 2024
|
Thanks for this and the other merges! Happily this means that roadrunner is back to using the develop branch of libsbml instead of its own offshoot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libsbml, a 'listOfElements' from the spec is called a 'listOfCurveElements' because of unique naming constraints. However, when reading in an SBML file, the list was requried to be called 'listOfCurveElements' instead of 'listOfElements'. This meant that when libsbml wrote out a file with a 'listOfElements' child of a 'RenderCurve', it couldn't be read back in again.
Instead of changing the required name from 'listOfCurveElements' to 'listOfElements', this change allows both, for backwards compatibility.
I added a test file for validation, but it isn't super compact; it's just the file we had created when we found the bug in the first place.