Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- ensure expat can be found when crosscompiling #368

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

fbergmann
Copy link
Member

Description

expat is currently not found when crosscompiling, this commit fixes the issue

Motivation and Context

fixes the issue that pyodide cant compile libsbml

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann requested a review from skeating April 12, 2024 12:25
@fbergmann
Copy link
Member Author

@skeating, the test failure has nothing to do with the changes in this PR, just letting you know

@skeating skeating merged commit 6f35dde into development Apr 14, 2024
27 checks passed
@skeating skeating deleted the cmake-script-update branch April 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants