Merge remote-tracking branch 'origin/sk/test-rate-rule-converter-rigo…

…rously' into sk/test-rate-rule-converter-rigorously
sbmlteam · Oct 6, 2024 · f20f07b · f20f07b
2 parents 1c8fafe + 9370f2b
commit f20f07b
Show file tree

Hide file tree

Showing 17 changed files with 920 additions and 809 deletions.
diff --git a/src/sbml/SBMLErrorTable.h b/src/sbml/SBMLErrorTable.h
@@ -11047,8 +11047,7 @@ static const sbmlErrorTableEntry errorTable[] =
     "LibSBML expected to read the annotation into a ModelHistory "
     "object. Unfortunately, some attributes were not present or correct "
     "and the resulting ModelHistory object will not correctly "
-    "produce the annotation.  This functionality will be improved in "
-    "later versions of libSBML. ",
+    "produce the annotation.  ",
     {"",
      "",
      "L2V2 Section 6.3",
@@ -11076,8 +11075,7 @@ static const sbmlErrorTableEntry errorTable[] =
     "LibSBML expected to read the annotation into a ModelHistory "
     "object. Unfortunately, some attributes were not present or correct "
     "and the resulting ModelHistory object is NULL. Thus it will fail to "
-    "produce the annotation.  This functionality will be improved in "
-    "later versions of libSBML. ",
+    "produce the annotation. ",
     {"",
      "",
      "L2V2 Section 6.3",

diff --git a/src/sbml/SBase.cpp b/src/sbml/SBase.cpp
@@ -4576,6 +4576,7 @@ SBase::read (XMLInputStream& stream)
     else if ( next.isStart() )
     {
       const std::string nextName = next.getName();
+      const std::string nextURI = next.getURI();
 #if 0
       cout << "[DEBUG] SBase::read " << nextName << " uri "
            << stream.peek().getURI() << endl;
@@ -4620,7 +4621,7 @@ SBase::read (XMLInputStream& stream)
                    || readAnnotation(stream)
                    || readNotes(stream) ))
       {
-        logUnknownElement(nextName, getLevel(), getVersion());
+        logUnknownElement(nextName, getLevel(), getVersion(), nextURI);
         stream.skipPastEnd( stream.next() );
       }
     }
@@ -5343,11 +5344,17 @@ SBase::logUnknownAttribute( const string& attribute,
 void
 SBase::logUnknownElement( const string& element,
         const unsigned int level,
-        const unsigned int version )
+        const unsigned int version,
+    const string& URI)
 {
   bool logged = false;
   ostringstream msg;
 
+  // if we have an unknown element that is not in an SBML name space
+  // this is perfectly allowed XML
+  if (getPackageName() == "core" && SBMLNamespaces::getSBMLNamespaceURI(level, version) != URI)
+      return;
+
   if (level > 2 && getTypeCode() == SBML_LIST_OF)
   {
     int tc = static_cast<ListOf*>(this)->getItemTypeCode();

diff --git a/src/sbml/SBase.h b/src/sbml/SBase.h
@@ -3532,7 +3532,8 @@ newModel.addSpecies(s1);
    */
   void logUnknownElement( const std::string& element,
         const unsigned int level,
-        const unsigned int version );
+        const unsigned int version,
+      const std::string& URI = NULL);
 
 
   /**