Add typing to public API #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Aug 22, 2024
tox.ini
Outdated
Comment on lines
26
to
30
| [testenv:typing] | ||
| deps = | ||
| mypy | ||
| commands = | ||
| mypy |
There was a problem hiding this comment.
Would it be useful to also add mypy to CI?
There was a problem hiding this comment.
Since CI runs tox, wouldn't this be run in CI anyway?
There was a problem hiding this comment.
It won’t because you did not add it to envlist
There was a problem hiding this comment.
So that means that tests are also not being run (and looking at CI logs, that is the case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #69