Implement include-what-you-use policy #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the include-what-you-use policy to clean up cross-references between headers and clearly show what actually is used inside a file. While this is by far not the minimal set of headers allowed to be included, this gives a good and stable set of includes to avoid breakage if something is moved around. Also the tool iwyu allows to detect headers that are included but never used.
This PR includes three patches:
Note that IWYU uses a fixed clang version. Thus if IWYU is compiled to use a certain clang version you need to provide the proper clang binary and system include files or IWYU will report missing files even though normal compilation succeeds. See the documentation of Include-What-You-Use for details.