ci: fix versions

sandre58 · May 6, 2024 · 661009f · 661009f
1 parent 56a61af
commit 661009f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -55,7 +55,7 @@ jobs:
     needs: [ gitversion ]
     with:
       name: Build
-      build-args: '/p:GitVersion=${{ needs.gitversion.outputs.full_version }} /p:VersionSuffix=${{ needs.gitversion.outputs.suffix_label }}'
+      build-args: '/p:Version=${{ needs.gitversion.outputs.full_version }}'
       dotnet-test-logger: GitHubActions --no-build --no-restore
       solution-path: .\src\MyIconCreator.sln
       nugetFeedUrl: ${{ vars.PRIVATE_NUGET_API_SOURCE }}

diff --git a/.github/workflows/create_release.yml b/.github/workflows/create_release.yml
@@ -52,7 +52,7 @@ jobs:
     needs: [ gitversion ]
     with:
       name: Build
-      build-args: '/p:GitVersion=${{ needs.gitversion.outputs.full_version }} /p:VersionSuffix=${{ needs.gitversion.outputs.suffix_label }}'
+      build-args: '/p:Version=${{ needs.gitversion.outputs.full_version }}'
       dotnet-test-logger: GitHubActions --no-build --no-restore
       solution-path: .\src\MyIconCreator.sln
       nugetFeedUrl: ${{ vars.PRIVATE_NUGET_API_SOURCE }}

diff --git a/src/Directory.build.props b/src/Directory.build.props
@@ -12,6 +12,7 @@
 
 <!-- Configuration -->
   <PropertyGroup>
+    <TargetFrameworks>net8.0</TargetFrameworks>
     <BaseOutputPath>bin</BaseOutputPath>
     <AppendTargetFrameworkToOutputPath>true</AppendTargetFrameworkToOutputPath>
     <Configuration Condition="'$(Configuration)' == ''">Release</Configuration>