WIP Green sirenia or bust! #6976

dlpierce · 2024-11-22T23:12:56Z

Fixes #6894

Summary

Get Sirenia specs passing and add to test matrix

Detailed Description

Many fixes for specs broken in sirenia (fedora 6/valkyrie). See individual commmit messages.

Docker compose files have been reworked to use the same image.

Currently needs valkyrie main branch until a new release is cut.

Known issues:

Custom queries added in 5592 dashboard statistics page error #6088 are SQL specific and not compatible with valkyrie's fedora adapter.
Chrome is acting flaky again.

Ldp::Gone is the error raised by the fedora adapter when the resource is a tombstone after being deleted.

The valkyrie fedora adapter does not convert RDF Date causing comparison failures. In real use the embargo transaction converts to a datetime, but this factory sets the value directly, so let's make it match real use.

This fixes file_set_indexer_spec which has a bunch of odd setup and mocking, likely from before our factories were equipped to handle building work/file_set/file_metadata stacks. However, it feels right to include here and be treated as an ObjectNotFoundError.

- All 3 test apps use the same container image. - dassie stays in hyrax-webapp, koppie/sirenia live in hyrax-koppie. - db_migrate service moved to dev-entrypoint in web service. - Worker waits to start until rails app is up, should reduce bundle install racing. - hyrax-engine-dev target now based on hyrax-worker-base. - Chrome is still a pain and randomly stops responding.

github-actions · 2024-11-22T23:15:37Z

Test Results

10 files - 7 10 suites - 7 1h 21m 0s ⏱️ - 55m 31s
5 268 tests - 1 465 5 135 ✅ - 1 302 107 💤 - 189 26 ❌ +26
13 153 runs - 87 12 912 ✅ + 71 207 💤 - 192 34 ❌ +34

For more details on these failures, see this check.

Results for commit 9706493. ± Comparison against base commit abd5955.

This pull request removes 1683 and adds 218 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f407a6c2f98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007feffe221410>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f407a631548>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007feffd2bfa08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: de734d03-6e8f-4678-a8ef-c23fec5bcca2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d2cb4476-ff08-4ad4-bb60-56a96e85289e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 88ac13a0-43fd-49fd-989b-ba2da02a477a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 7eb7c9a7-7ff5-438e-9080-d814a85b4d2c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: f4cd4d33-8f3a-4357-9ba7-9829729feaae
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 5e98a598-2ecb-49e3-b766-39197563c7cc
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1b89a87810>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fcb5278be08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1b88fe6190>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fcb528e2310>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 28242d40-7444-43bd-9d67-51f561141fec
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 9f40448b-bf47-4f59-b7d4-055ca76a9560
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 0d62c773-696d-4c8e-9cc7-09664216b42e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 650aaaf8-8415-4ed4-8eee-41f8f5f361bc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 25be2c03-3fec-43db-a017-324e449ce727
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 5ded8358-51b6-4cc4-b983-c04ffe9b2ef0
…

This pull request skips 7 tests.

spec.controllers.hyrax.fixity_checks_controller_spec ‑ Hyrax::FixityChecksController when signed in POST create returns json with the result
spec.jobs.create_work_job_spec ‑ CreateWorkJob#perform with an ActiveFedora model when the actor does not create the work logs the failure
spec.jobs.create_work_job_spec ‑ CreateWorkJob#perform with an ActiveFedora model when the update is successful logs the success
spec.jobs.migrate_files_to_valkyrie_job_spec ‑ MigrateFilesToValkyrieJob it migrates all derivatives along with a file
spec.models.hyrax.permission_template_spec ‑ Hyrax::PermissionTemplate#source_model when source is a Collection returns a Collection if the source_type is collection for the given permission_template
spec.models.hyrax.permission_template_spec ‑ Hyrax::PermissionTemplate#source_model when source is an AdminSet returns an AdminSet if the source_type is admin_set for the given permission_template
spec.services.hyrax.work_uploads_handler_spec ‑ Hyrax::WorkUploadsHandler#attach after adding files when running background jobs persists the uploaded files asynchronously

♻️ This comment has been updated with latest results.

dlpierce added 12 commits November 15, 2024 17:03

Convert Ldp::Gone to ObjectNotFoundError

8401205

Ldp::Gone is the error raised by the fedora adapter when the resource is a tombstone after being deleted.

Use the real metadata adapter

8ef01af

Ensure embargo/lease factory is using DateTime

abefbab

The valkyrie fedora adapter does not convert RDF Date causing comparison failures. In real use the embargo transaction converts to a datetime, but this factory sets the value directly, so let's make it match real use.

Avoid using << on frozen default array in specs

06ae6ba

Sometimes the original file is not first in file_ids

1e0af65

Fix specs stubbing Hyrax::TimeService with a string

f405511

More date format spec fixes

4bb73c9

Limit rails versions to speed dependency resolution

6ddfbb8

Bump valkyrie, use main until new release

24e918e

Unpin faraday, rdf 3.3.2 fixed the bug

88667ec

dlpierce added notes-bugfix Release Notes: Fixed a bug notes-container Release Notes: Docker, Helm, etc notes-tests Release Notes: Spec or CI changes labels Nov 22, 2024

rubocop

9706493

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP Green sirenia or bust! #6976

WIP Green sirenia or bust! #6976

dlpierce commented Nov 22, 2024

github-actions bot commented Nov 22, 2024 •

edited

Loading

WIP Green sirenia or bust! #6976

Are you sure you want to change the base?

WIP Green sirenia or bust! #6976

Conversation

dlpierce commented Nov 22, 2024

Summary

Detailed Description

github-actions bot commented Nov 22, 2024 • edited Loading

Test Results

github-actions bot commented Nov 22, 2024 •

edited

Loading