Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embargo/Lease form fixes #6970

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Embargo/Lease form fixes #6970

merged 4 commits into from
Nov 8, 2024

Conversation

dlpierce
Copy link
Contributor

@dlpierce dlpierce commented Nov 8, 2024

Fixes

Fixes #6782
Fixes #6784
Fixes display of resource title on embargo/lease edit form

Changes proposed in this pull request:

  • Move location of deactivate button to the existing second row of each resource entry. This avoids having a column without a header, and avoids adding an "Actions" header to the other embargo tables.
  • Add a to_s method to WorkEmbargoForm that is displayed on the form instead of the generic ruby object to_s
  • Do these same fixes for leases too

@samvera/hyrax-code-reviewers

Copy link

github-actions bot commented Nov 8, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 15m 22s ⏱️ - 1m 17s
 6 729 tests ±0   6 432 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit e22b8f1. ± Comparison against base commit 1584e11.

This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f98898c4258>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb5fd490a10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f988988ed88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb5fde994d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 54e845c4-8ad9-4db0-8438-0d3be84a5e85
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 4aca17a8-463f-4da7-b0e2-83a47c121b46
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: ba3a254a-f453-4ba4-b41c-f8271df845b3
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: e45a2916-9eae-4c6b-b6a8-f781cf6caee1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 1ddf2e6a-5f56-4aca-bae2-f867fb37a557
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 60b3dbfa-dcf7-4bb7-893f-61a493654dce
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f446fb97a98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f604a4badc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4467626918>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f6047b31f60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: e9add00f-8a15-4cc8-8b4b-89096b606d5c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 299476ea-3b12-4d8d-9b06-f4eca54bbab2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 6133a672-47c5-4375-a624-44b336b1d7bc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: fbc17d09-20ef-4658-be12-fb0b71a82866
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: f3fdcd51-0255-45ea-ab75-93465ce3d76e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 8fcb77ce-8676-47d4-a818-66811f021c1c
…

♻️ This comment has been updated with latest results.

randalldfloyd
randalldfloyd previously approved these changes Nov 8, 2024
@dlpierce dlpierce merged commit ae082d1 into main Nov 8, 2024
22 checks passed
@dlpierce dlpierce deleted the embargo-form-fixes branch November 8, 2024 19:51
@dlpierce dlpierce added the notes-accessibility Release Notes: Accessibility label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-accessibility Release Notes: Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deactivate Lease button missing context Deactivate embargo button is missing context
2 participants