-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embargo/Lease form fixes #6970
Merged
Merged
Embargo/Lease form fixes #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files ±0 17 suites ±0 2h 15m 22s ⏱️ - 1m 17s Results for commit e22b8f1. ± Comparison against base commit 1584e11. This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
randalldfloyd
previously approved these changes
Nov 8, 2024
randalldfloyd
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6782
Fixes #6784
Fixes display of resource title on embargo/lease edit form
Changes proposed in this pull request:
to_s
method to WorkEmbargoForm that is displayed on the form instead of the generic ruby objectto_s
@samvera/hyrax-code-reviewers