[electron-chrome-extensions] handle a tab of null explicitly as no tab in executeScript #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extensions use
nullas the value for the tabID, and Chromium handles this as if it is not there. This change updates theelectron-browser-shellimplementation such that the behavior is the same.This enables support for the snapfont extension, which uses
tab.executeScript(null, {file: ....})to add support for webComponents. Currently this is ignored, causing the content script to fail.✅ By sending this pull request, I agree to the Contributor License Agreement of this project.