Added scrutinizer [SLE-197]

.github/workflows/build.yml

@@ -7,9 +7,6 @@ on:
   pull_request:
     types: [ opened, synchronize, reopened ]
 
-env:
-  APP_ENV: github
-
 jobs:
   run:
     runs-on: ${{ matrix.operating-system }}
@@ -77,6 +74,7 @@ jobs:
         run: mysql -uroot -proot -D ${{ matrix.test-database }} -e "SHOW TABLES;"
 
       - name: Run test suite
-        run: composer test:coverage
+        run: composer test
         env:
-          PHP_CS_FIXER_IGNORE_ENV: 1
+          APP_ENV: github
+          PHP_CS_FIXER_IGNORE_ENV: 1

.scrutinizer.yml

@@ -0,0 +1,46 @@
+filter:
+    paths: [ "src/*" ]
+    excluded_paths: [ "vendor/*", "tests/*", "resources/", "public/" ]
+
+checks:
+    php:
+        code_rating: true
+        duplication: true
+
+tools:
+    external_code_coverage: false
+
+build:
+    services:
+        mysql: 8.0.29
+    environment:
+        php:
+            version: 8.2
+            ini:
+                xdebug.mode: coverage
+        mysql: 5.7
+        node: false
+        postgresql: false
+        mongodb: false
+        elasticsearch: false
+        redis: false
+        memcached: false
+        neo4j: false
+        rabbitmq: false
+        variables:
+            APP_ENV: 'github'
+    nodes:
+        analysis:
+            tests:
+                override:
+                    - php-scrutinizer-run
+    dependencies:
+        before:
+            - composer self-update
+            - mysql -u root -e "CREATE DATABASE IF NOT EXISTS slim_api_example_test CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci;"
+    tests:
+        before:
+            -   command: composer test:coverage
+                coverage:
+                    file: 'build/logs/clover.xml'
+                    format: 'clover'

src/Application/Action/User/UserCreateAction.php

@@ -2,8 +2,8 @@
 
 namespace App\Application\Action\User;
 
-use Fig\Http\Message\StatusCodeInterface;
 use App\Domain\User\Service\UserCreator;
+use Fig\Http\Message\StatusCodeInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 

src/Domain/User/Repository/UserCreatorRepository.php

@@ -8,19 +8,19 @@
 {
     public function __construct(
         private QueryFactory $queryFactory,
-    )
-    {
+    ) {
     }
 
     /**
      * Insert user values into database.
      *
      * @param array $userValues
+     *
      * @return int
      */
     public function insertUser(array $userValues): int
     {
         // Insert user into database
         return (int)$this->queryFactory->insertQueryWithData($userValues)->into('user')->execute()->lastInsertId();
     }
-}
+}

src/Domain/User/Service/UserCreator.php

@@ -2,9 +2,7 @@
 
 namespace App\Domain\User\Service;
 
-use App\Domain\User\Data\UserData;
 use App\Domain\User\Repository\UserCreatorRepository;
-use App\Domain\User\Repository\UserFinderRepository;
 
 final readonly class UserCreator
 {
@@ -15,7 +13,9 @@ public function __construct(
     }
 
     /**
-     * Create new user with given values
+     * Create new user with given values.
+     *
+     * @param array $userValues
      *
      * @return int user id
      */

src/Domain/User/Service/UserValidator.php

@@ -7,11 +7,10 @@
 
 /**
  * User validation.
- * Documentation: https://github.com/samuelgfeller/slim-example-project/wiki/Validation
+ * Documentation: https://github.com/samuelgfeller/slim-example-project/wiki/Validation.
  */
 final readonly class UserValidator
 {
-
     /**
      * Validate user values.
      *
@@ -27,15 +26,15 @@ public function validateUserValues(array $userValues, bool $isCreateMode = true)
 
         $validator
             ->requirePresence('first_name', $isCreateMode, 'Field is required')
-            ->allowEmptyString('first_name',) // Not required field
+            ->allowEmptyString('first_name') // Not required field
             ->minLength('first_name', 2, 'Minimum length is 2')
             ->maxLength('first_name', 100, 'Maximum length is 100')
             ->requirePresence('last_name', $isCreateMode, 'Field is required')
-            ->allowEmptyString('last_name',) // Not required field
+            ->allowEmptyString('last_name') // Not required field
             ->minLength('last_name', 2, 'Minimum length is 2')
             ->maxLength('last_name', 100, 'Maximum length is 100')
             ->requirePresence('email', $isCreateMode, 'Field is required')
-            ->allowEmptyString('first_name',) // Not required field
+            ->allowEmptyString('first_name') // Not required field
             ->email('email', false, 'Invalid email')
         ;
 

tests/Integration/User/UserCreateActionTest.php

@@ -36,4 +36,4 @@ public function testUserCreateAction(): void
         // Assert that the user was created in the database
         $this->assertTableRow($testUserData, 'user', $testUserData['id']);
     }
-}
+}