Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add big-endian case (arch: s390x) as allow_failures. #970

Closed
wants to merge 1 commit into from

Conversation

junaruga
Copy link
Contributor

It is related to #355 .

#355 (comment)

It won't break the amd64 test cases, but it will break the build as a whole. Once the remaining issues have been tracked down and fixed it will be useful to turn this on so that they don't regress, but it would be rather distracting at the moment.

This PR is to add s390x case as allow_failures with fast_finish: true option.

allow_failures is to ignore the result of the test case that is set as "allow_failures".
As a result, as Travis is green (succeeded) even when the s390x case is failed, "it will not break the build as a whole".

fast_finish: true option is return the entire result without waiting the test case that is set as "allow_failures". As a result, we are not disturbed by the case.

Here is my forked repository's result.
https://travis-ci.org/junaruga/htslib/builds/611619509

I admit that the s390x case is slow at the moment.
But we can see the useful result.

https://travis-ci.org/junaruga/htslib/jobs/611619519#L335

Unexpected failures: 4

@junaruga
Copy link
Contributor Author

junaruga commented Nov 14, 2019

I would close this PR as I got feedback from John.
I like you adapt it when you like it in the future.
Sorry for disturbing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant