Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional java versions to our test matrix and toolchains #1723

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,18 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java: [ 17 ]
java: [ 17, 21]
experimental: [false]
include:
- java: 23
experimental: true
fail-fast: false
continue-on-error: ${{ matrix.experimental }}
name: Java ${{ matrix.Java }} build and test
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up java ${{ matrix.Java }}
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.Java }}
distribution: 'adopt'
Expand All @@ -39,7 +42,7 @@ jobs:
run: ./gradlew test jacocoTestReport
- name: Upload test results
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-results-${{ matrix.Java }}
path: build/reports/tests
Expand All @@ -48,9 +51,9 @@ jobs:
runs-on: ubuntu-latest
name: Tests that require external APIs
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up java 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'adopt'
Expand All @@ -65,7 +68,7 @@ jobs:
# run: bash <(curl -s https://raw.githubusercontent.com/broadinstitute/codecov-bash-uploader/main/codecov-verified.bash)
- name: Upload test results
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-results-external-apis
path: build/reports/tests
Expand All @@ -74,9 +77,9 @@ jobs:
runs-on: ubuntu-latest
name: FTP tests
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up java 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'adopt'
Expand All @@ -91,17 +94,17 @@ jobs:
# run: bash <(curl -s https://raw.githubusercontent.com/broadinstitute/codecov-bash-uploader/main/codecov-verified.bash)
- name: Upload test results
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-results-ftp
path: build/reports/tests
spotBugs:
runs-on: ubuntu-latest
name: SpotBugs
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up java 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'adopt'
Expand All @@ -112,7 +115,7 @@ jobs:
run: ./gradlew spotBugsMain spotBugsTest
- name: Upload spotBugs Report
if: failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: spotBugs-Report
path: build/reports/spotbugs
Expand Down
4 changes: 4 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ dependencies {
java {
toolchain {
languageVersion = JavaLanguageVersion.of(17)
languageVersion = JavaLanguageVersion.of(21)
languageVersion = JavaLanguageVersion.of(22)
languageVersion = JavaLanguageVersion.of(23)
}
withJavadocJar()
withSourcesJar()
Expand All @@ -64,6 +67,7 @@ defaultTasks 'jar'

tasks.withType(JavaCompile).configureEach {
options.encoding = 'UTF-8'
options.release.set(17)
}

tasks.withType(Javadoc).configureEach {
Expand Down
Loading