Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcf: Valid contig ID in failed example #701

Open
zaeleus opened this issue Feb 6, 2023 · 1 comment
Open

vcf: Valid contig ID in failed example #701

zaeleus opened this issue Feb 6, 2023 · 1 comment
Labels

Comments

@zaeleus
Copy link

zaeleus commented Feb 6, 2023

test/vcf/4.3/failed/failed_meta_contig_003.vcf has a contig ID (1.*) marked as illegal but matches the name regex.

§ 1.4.7 "Contig field format" (2022-08-22):

[Contig names] match the following regular expression:

[0-9A-Za-z!#$%&+./:;?@^_|~-][0-9A-Za-z!#$%&*+./:;=?@^_|~-]*
@jmarshall jmarshall added the vcf label Feb 7, 2023
@jmarshall
Copy link
Member

jmarshall commented Feb 7, 2023

VCF's rules for contig IDs were changed in PR #379 (merged in March 2020) to align them with SAM's rules. As noted in §7.1, the main observable difference was relaxing the previous VCF prohibition on colons (in all VCF versions) and non-first * characters (only done explicitly in 4.3).

These test files were ported from EBI's VCF Validator, their origin predates this contig ID change, and they were insufficiently re-reviewed when PR #491 was merged in April 2021.

So this should be corrected to be a passing test file. Also requiring updating in the light of 2020's change:

  • 4.1/failed/failed_body_chrom_001.vcf
  • 4.2/failed/failed_body_chrom_001.vcf
  • 4.3/failed/failed_body_chrom_001.vcf
  • 4.3/failed/failed_body_chrom_004.vcf

@jkbonfield jkbonfield moved this to To do (backlog) in GA4GH File Formats Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do (backlog)
Development

No branches or pull requests

2 participants