Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React Router Routes on Page Refresh #5277

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rakshitbharat
Copy link

Fix React Router 404 Issues and Add Security Headers

Overview

  • Fixed 404 errors occurring on page refresh in the React SPA by updating Nginx configuration and added security headers for enhanced protection.

Technical Details

Nginx Configuration Changes

  • Added root location handler for all routes
  • Implemented try_files directive for proper SPA routing
  • Configured fallback to index.html for client-side routing
  • Maintained /dashboard/ path compatibility

Security Enhancements

Added essential security headers:

  • X-Frame-Options: SAMEORIGIN
  • X-XSS-Protection: 1; mode=block
  • X-Content-Type-Options: nosniff

Testing Performed

✅ Route refresh functionality
✅ Direct URL access
✅ Client-side navigation
✅ Security header presence

Breaking Changes
None. This is a non-breaking enhancement to existing functionality.

Copy link

changeset-bot bot commented Nov 23, 2024

⚠️ No Changeset found

Latest commit: cf78056

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rakshitbharat rakshitbharat requested a review from a team as a code owner November 27, 2024 07:50
Copy link
Member

@krzysztofzuraw krzysztofzuraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 Thanks for contribution

  1. Can you bring back .github / .husky folders - they are still needed 😄
  2. We are using npm and package-lock.json - remove bun.lockb as well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants