Home page information tiles #5271
Conversation
🦋 Changeset detectedLatest commit: 919ebe4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Cloud11PL
requested review from
andrzejewsky and
poulch
and removed request for
a team
Cloud11PL
force-pushed
the
MERX-1262-onboarding-component-accordion
branch
from
9a31df0
to
3cd53ae
Compare
Cloud11PL
force-pushed
the
MERX-1261-information-tiles
branch
from
f200f07
to
48bfb5e
Compare
| const DiscordIcon = () => <SVG src={discord} className={noShrink} />; | ||
| const ExternalLinkIcon = () => <SVG src={externalLink} className={noShrink} />; | ||
|
|
||
| export const getTilesData = ({ intl }: { intl: IntlShape }): InfoTile[] => [ |
There was a problem hiding this comment.
just a comment here - this force on you a specific structure for each tile, while you don't have eg. hundreds of them where you would need pre-defined structure. You have only few items and for that case simple composition would work better
There was a problem hiding this comment.
Imagine you need to change just a single tile now, in the way that not really fits this structure - it would need to probably opt-out from this
There was a problem hiding this comment.
I definitely understand the concern but in this case we had only tiles that had the exact same structure. Changing it to a more composable solution shouldn't take long if we decide that we're going to need it.
Cloud11PL
dismissed stale reviews from andrzejewsky and poulch
The base branch was changed.
Cloud11PL
force-pushed
the
MERX-1261-information-tiles
branch
from
48bfb5e
to
6a46add
Compare
Cloud11PL
force-pushed
the
MERX-1261-information-tiles
branch
from
d91af5a
to
919ebe4
Compare
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description