Fix a login error when using a password manager #5261
+92
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 189b7b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Cloud11PL
changed the title
poulch
approved these changes
Nov 19, 2024
poulch
approved these changes
Nov 26, 2024
Comment on lines
+216
to
+218
| const intl = useIntl(); | ||
| const notify = useNotifier(); | ||
| const apolloClient = useApolloClient(); |
There was a problem hiding this comment.
suggestion: IMO you should mock them
There was a problem hiding this comment.
I just checked, they're already mocked in the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It prevents 2 concurrent login attempts that sometimes happen when using a password manager (eg. 1Password). It caused not fully handled error regarding login attempt delay due to too many attempts from one IP. It also adds an error message for that case.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description