Refactor calculating highlight index logic for Combobox and Select #875
+15
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cab3fac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Released snapshot build with Install it with: pnpm add @saleor/[email protected] |
poulch
changed the title
poulch
requested review from
witoszekdev,
lkostrowski,
andrzejewsky,
Cloud11PL and
krzysztofzuraw
and removed request for
a team
krzysztofzuraw
previously approved these changes
Nov 19, 2024
krzysztofzuraw
approved these changes
Nov 19, 2024
poulch
added
release dev tag
|
Released snapshot build with Install it with: pnpm add @saleor/[email protected] |
andrzejewsky
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because...
This PR closes #...
Screenshots
Pull Request Checklist
./src/components/index.ts.forwardRef.