Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix otel pakcages versions #46

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix otel pakcages versions #46

merged 2 commits into from
Aug 21, 2024

Conversation

witoszekdev
Copy link
Member

Used otel library versions from saleor/apps, due to breaking changes making observability not working correctly

@witoszekdev witoszekdev requested a review from a team as a code owner August 21, 2024 10:53
@witoszekdev witoszekdev requested review from lkostrowski and removed request for a team August 21, 2024 10:53
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dummy-payment-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 11:59am

@lkostrowski
Copy link
Member

  • What was not working?
  • dont we need to update patch of the exporter?

@witoszekdev
Copy link
Member Author

@lkostrowski On never version I was getting following error:

The 'spanProcessor' option is deprecated. Please use 'spanProcessors' instead.
Accessing resource attributes before async attributes settled
API resolved without sending a response for /api/manifest, this may result in stalled requests.

I didn't get logs, nor traces in my local collector while testing it. After reverting the version back to the one in saleor/apps I got it to work.

@witoszekdev witoszekdev merged commit cd5676c into main Aug 21, 2024
5 checks passed
@witoszekdev witoszekdev deleted the fix-otel-version branch August 21, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants